Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Fetch + Cookies when using Node 18+ #48076

Merged
merged 2 commits into from
May 5, 2023
Merged

Fix Fetch + Cookies when using Node 18+ #48076

merged 2 commits into from
May 5, 2023

Conversation

BrennanConroy
Copy link
Member

Fixes #48040

@BrennanConroy BrennanConroy added area-signalr Includes: SignalR clients and servers feature-client-javascript Related to the SignalR JS client labels May 4, 2023
@BrennanConroy BrennanConroy requested a review from halter73 as a code owner May 4, 2023 17:24
mitchdenny
mitchdenny approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrennanConroy BrennanConroy merged commit a258916 into main May 5, 2023
@BrennanConroy BrennanConroy deleted the brecon/fetchnode18 branch May 5, 2023 15:22
@ghost ghost added this to the 8.0-preview5 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchdenny mitchdenny mitchdenny approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-signalr Includes: SignalR clients and servers feature-client-javascript Related to the SignalR JS client
Projects
None yet
Milestone
8.0-preview5
Development

Successfully merging this pull request may close these issues.

SignalR.Npm.FunctionalTests.npmproj fail on Fedora 37+
2 participants
@BrennanConroy @mitchdenny