Enable prebuilt detection #47894
Merged
Enable prebuilt detection #47894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add some missing depenencies with source-build tags - Update baseline - Remove some unused NuGet properties - Remove old source build workaround - Remove explicit reference to Microbuild.Core - Pass DotNetBuildFromSource to the repo tasks inner build environment
ghost
added
the
area-infrastructure
27 tasks
wtgodbe
reviewed
Apr 26, 2023
| <UsagePattern IdentityGlob="Microsoft.SourceBuild.Intermediate.*/*" /> | ||
|
|
||
| <!-- These are used in-build for repo-tasks and should come from previously source built --> | ||
| <UsagePattern IdentityGlob="NuGet.Common/*6.2.2*" /> |
There was a problem hiding this comment.
Will we have to maintain these hardcoded versions?
There was a problem hiding this comment.
Why not use the versions from Versions.props?
There was a problem hiding this comment.
This isn't loaded by msbuild. They will need to be maintained, but I assume they will not update too often.
There was a problem hiding this comment.
Will we see an error if we update the related package versions but don't update these? Want to make sure we don't let it fall behind
wtgodbe
reviewed
Apr 26, 2023
eng/tools/RepoTasks/RepoTasks.csproj
Outdated
| @@ -23,6 +23,8 @@ | |||
| <PackageReference Include="Microsoft.Build.Framework" Version="$(MicrosoftBuildFrameworkVersion)" /> | |||
| <PackageReference Include="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildTasksCoreVersion)" /> | |||
| <PackageReference Include="Microsoft.Build.Utilities.Core" Version="$(MicrosoftBuildUtilitiesCoreVersion)" /> | |||
| <!-- Manually updated version from 6.0.0 to address CVE-2021-43877 --> | |||
| <PackageReference Include="System.Security.Cryptography.Xml" Version="6.0.1" /> | |||
There was a problem hiding this comment.
We should property-ize this and put it in Versions.props
There was a problem hiding this comment.
Done. It differs from the 8.0 version so I chose a different property name
|
@wtgodbe Looking good now. |
wtgodbe
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{PR title}
Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)