Add AOT flag to worker template #47721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
requested review from
DamianEdwards,
JamesNK,
mitchdenny and
captainsafia
ghost
added
the
area-mvc
dotnet-issue-labeler
bot
added
the
area-mvc
|
Are there template tests for worker? Should add aot publish |
Fix Api template tests for NativeAOT to pass locally.
Done. I left them skipped for now until #47247 is fixed. |
|
Anyone have any feedback here? |
captainsafia
approved these changes
Apr 19, 2023
| @@ -35,7 +35,7 @@ public async Task ApiTemplateCSharp() | |||
| await ApiTemplateCore(languageOverride: null); | |||
| } | |||
|
|
|||
| [ConditionalFact(Skip = "Unskip when there are no more build or publish warnings for native AOT.")] | |||
| [ConditionalFact(Skip = "Unskip when Helix supports native AOT. https://github.com/dotnet/aspnetcore/pull/47247/")] | |||
There was a problem hiding this comment.
Nit: Should we update the tests in the gRPC templates with an issue reference as well?
There was a problem hiding this comment.
The Grpc template tests are getting updated in that PR already. We can just wait for that PR to get clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-aotflag is available in theapi,grpc, and soon to be in theconsoletemplates. Theworkertemplate is compatible with NativeAOT, so it should have the option as well.Fix #46541