Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC JSON transcoding: Fix body binding to repeated message or map #47511

Merged
merged 2 commits into from
Mar 31, 2023
Merged

gRPC JSON transcoding: Fix body binding to repeated message or map #47511

merged 2 commits into from
Mar 31, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Mar 31, 2023 •
edited
Loading

Fixes #47510

Repeated body binding worked with primitive fields but not messages. Also, it didn't work with maps. Fixed together.

@JamesNK JamesNK added the area-grpc Includes: GRPC wire-up, templates label Mar 31, 2023
@JamesNK JamesNK merged commit 0706ea3 into main Mar 31, 2023
@JamesNK JamesNK deleted the jamesnk/jsontranscoding-body branch March 31, 2023 07:10
@ghost ghost added this to the 8.0-preview4 milestone Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchdenny mitchdenny mitchdenny approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@amcasey amcasey Awaiting requested review from amcasey

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees
No one assigned
Labels
area-grpc Includes: GRPC wire-up, templates
Projects
None yet
Milestone
8.0-preview4
Development

Successfully merging this pull request may close these issues.

Grpc transcoding in .net 7 - cannot post repeated field
2 participants
@JamesNK @mitchdenny