-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Enable AOT template tests #47247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AOT template tests #47247
Changes from all commits
4a10a00
ec8100a
161bf29
b3e73a9
0d7d3e8
69f6430
d6431be
87c6f76
069bb91
2b6e995
2205c17
ef17e9b
826b052
2570397
169541d
cea46ee
70882ef
741be08
0d3a4c3
b725963
011444b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using Microsoft.AspNetCore.Testing; | ||
using Microsoft.Extensions.Logging.Testing; | ||
using Templates.Test.Helpers; | ||
using Xunit.Abstractions; | ||
|
||
|
@@ -35,7 +36,8 @@ public async Task ApiTemplateCSharp() | |
await ApiTemplateCore(languageOverride: null); | ||
} | ||
|
||
[ConditionalFact(Skip = "Unskip when Helix supports native AOT. https://github.com/dotnet/aspnetcore/pull/47247/")] | ||
[ConditionalFact] | ||
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/47478", Queues = "OSX.13.Amd64.Open;Ubuntu.2004.Amd64.Open;Windows.11.Amd64.Client.Open;")] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This set of queues seems duplicated a bunch of times. Maybe have a const in this project and append const here and elsewhere? It makes updating it easier in the future. |
||
public async Task ApiTemplateNativeAotCSharp() | ||
{ | ||
await ApiTemplateCore(languageOverride: null, args: new[] { ArgConstants.PublishNativeAot }); | ||
|
@@ -47,7 +49,8 @@ public async Task ApiTemplateProgramMainCSharp() | |
await ApiTemplateCore(languageOverride: null, args: new[] { ArgConstants.UseProgramMain }); | ||
} | ||
|
||
[ConditionalFact(Skip = "Unskip when Helix supports native AOT. https://github.com/dotnet/aspnetcore/pull/47247/")] | ||
[ConditionalFact] | ||
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/47478", Queues = "OSX.13.Amd64.Open;Ubuntu.2004.Amd64.Open;Windows.11.Amd64.Client.Open;")] | ||
public async Task ApiTemplateProgramMainNativeAotCSharp() | ||
{ | ||
await ApiTemplateCore(languageOverride: null, args: new[] { ArgConstants.UseProgramMain, ArgConstants.PublishNativeAot }); | ||
|
@@ -93,7 +96,6 @@ private async Task ApiTemplateCore(string languageOverride, string[] args = null | |
Assert.False( | ||
aspNetProcess.Process.HasExited, | ||
ErrorMessages.GetFailedProcessMessageOrEmpty("Run built project", project, aspNetProcess.Process)); | ||
|
||
await AssertEndpoints(aspNetProcess); | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,7 @@ | |
|
||
namespace Microsoft.AspNetCore.Server.HttpSys.FunctionalTests; | ||
|
||
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why don't these tests run on this queue? Is HTTP.sys and IIS not on the image? It would be good to have a better description in the attribute. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are all the HTTP.sys and IIS functional tests skipped? If so, SkipOnHelix attribute might work on the assembly. Avoids modifying so many files. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Based on the usage attributes the SkipOnHelix attribute doesn't work at the assembly level. The reason I am disabling these tests is that they are causing failtures due to hitting some 40m threshold. I'm not certain if it's that IIS just won't work on that image or if it is something else at this stage. |
||
public class Http2Tests : LoggedTest | ||
{ | ||
private const string VersionForReset = "10.0.19529"; | ||
|
Uh oh!
There was an error while loading. Please reload this page.