Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous route detection for [Route] with HTTP methods #47106

Merged
merged 5 commits into from
Mar 9, 2023
Merged

Fix ambiguous route detection for [Route] with HTTP methods #47106

merged 5 commits into from
Mar 9, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Mar 9, 2023

Fixes #46936

@JamesNK JamesNK added the area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Mar 9, 2023
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 9, 2023
@JamesNK JamesNK removed the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 9, 2023
@JamesNK JamesNK mentioned this pull request Mar 9, 2023
Closed
1 task
captainsafia
captainsafia approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I see now that the code was actually only looking for HttpAction attributes with the template provided as a constructor argument for the attribute and that's why the bug came up.

src/Framework/AspNetCoreAnalyzers/test/Mvc/DetectAmbiguousActionRoutesTest.cs Show resolved Hide resolved
@JamesNK JamesNK merged commit 114171c into main Mar 9, 2023
@JamesNK JamesNK deleted the jamesnk/route-httpmethod branch March 9, 2023 10:33
@ghost ghost added this to the 8.0-preview3 milestone Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

Assignees
No one assigned
Labels
area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Projects
None yet
Milestone
8.0-preview3
Development

Successfully merging this pull request may close these issues.

ASP0023 Ambiguous route warning when targeting .NET 8 and using both [Http*] and [Route] attributes
2 participants
@JamesNK @captainsafia