Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to ASP.NET Core #46834

Merged
merged 9 commits into from
Apr 12, 2023
Merged

Add metrics to ASP.NET Core #46834

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5286a31
Add metrics factory
JamesNK Feb 23, 2023
eca625e
Fix test, PR feedback
JamesNK Apr 8, 2023
23ece4e
PR and review feedback
JamesNK Apr 11, 2023
26c4f98
Fix build
JamesNK Apr 11, 2023
80a177b
Fix build
JamesNK Apr 12, 2023
07f6594
Add TODO comment
JamesNK Apr 12, 2023
73851dd
Update src/Hosting/Hosting/src/Internal/HostingMetrics.cs
JamesNK Apr 12, 2023
8c136e0
Update src/Hosting/Hosting/src/Internal/HostingMetrics.cs
JamesNK Apr 12, 2023
9b728ec
Fix tests
JamesNK Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix build
  • Loading branch information
@JamesNK
JamesNK committed Apr 11, 2023
commit 26c4f984adfee7cb47d0f74a3f995cf0fe7d868e
2 changes: 1 addition & 1 deletion src/Hosting/Hosting/src/Internal/HostingApplicationDiagnostics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public void BeginRequest(HttpContext httpContext, HostingApplication.Context con
else
{
context.MetricsTagsFeature ??= new HttpMetricsTagsFeature();
httpContext.Features.Set(context.MetricsTagsFeature);
httpContext.Features.Set<IHttpMetricsTagsFeature>(context.MetricsTagsFeature);
}

startTimestamp = Stopwatch.GetTimestamp();
Expand Down
1 change: 0 additions & 1 deletion src/Middleware/RateLimiting/samples/RateLimitingSample/RateLimitingSample.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
<Reference Include="Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore" />
<Reference Include="Microsoft.AspNetCore.HttpsPolicy" />
<Reference Include="Microsoft.AspNetCore.Http.Results" />
<Reference Include="Microsoft.AspNetCore.Mvc" />
<Reference Include="Microsoft.AspNetCore.RateLimiting" />
<Reference Include="Microsoft.EntityFrameworkCore.InMemory" />
<Reference Include="Microsoft.Extensions.DependencyInjection" />
Expand Down