gRPC JSON transcoding: Fix not supporting JSON name in querystring names #46624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
ReubenBond,
BrennanConroy,
amcasey and
benjaminpetit
JamesNK
changed the title
JamesNK
changed the title
mgravell
reviewed
Feb 17, 2023
JamesNK
commented
Feb 17, 2023
src/Grpc/JsonTranscoding/src/Shared/ServiceDescriptorHelpers.cs
Outdated
Show resolved
Hide resolved
mgravell
approved these changes
Feb 17, 2023
ghost
added this to the 
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/4219867289 |
Merged
11 tasks
1 task
|
Note the odd naming thing is now fixed; we should probably mirror that in the transcoding layer |
|
Hi @mgravell. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #45753 (the issue reports two bugs)
Message fields have two names: the internal field name, which is conventionally
underscore_case, and the JSON name, which is conventionallycamelCase. The JSON name can be specified manually or automatically calculated from the field name, e.g.full_name->fullName.gRPC JSON transcoding supports binding query string values to message fields. The query string name can be either the field or JSON name. JSON names were not supported. This PR fixes that.