Update CreateSlimBuilder to use Host.CreateEmptyApplicationBuilder. #46579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix 2 existing bugs: 1. ContentRootPath is set to the app's BaseDirectory, and not CurrentWorkingDirectory. Default to CWD by using the same logic as HostApplicationBuilder. 2. Add un-prefixed environment variables to the configuration, and ensure the configuration order is the same as WebApplication.CreateBuilder. Fix dotnet#46293
ghost
added
the
eerhardt
added
area-web-frameworks
|
@halter73 - any feedback here? |
halter73
approved these changes
Feb 16, 2023
| // add the default host configuration sources, so they are picked up by the HostApplicationBuilder constructor. | ||
| // These won't be added by HostApplicationBuilder since DisableDefaults = true. | ||
| // SetDefaultContentRoot needs to be added between 'ASPNETCORE_' and 'DOTNET_' in order to match behavior of the non-slim WebApplicationBuilder. | ||
| SetDefaultContentRoot(options, configuration); |
There was a problem hiding this comment.
You could do this before adding any configuration, right? SetDefaultContentRoot tries not to override any explicit config, so order shouldn't really matter. If we do it first, we could probably get rid of configuration[HostDefaults.ContentRootKey] is null, but I understand keeping it the same for consistency.
There was a problem hiding this comment.
Yeah, it probably could, but I like keeping the logic consistent, so if we ever need to update one it would be straight forward to update the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix 2 existing bugs:
Fix #46293