Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor named pipes connection listener completion #46521

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 8, 2023

Two changes:

  1. Move completion of the channel out of listener queues. Previously the first queue to exit would complete the channel. There is the chance another queue has just accepted a connection and attempts to put it on the channel and fails.
  2. The ConnectionListenerAborted log was written inside each listener queue. That means when the transport was disposed of, it was logged 16 times. Move the log to completion, and only log if there was an error. This more closely matches sockets transport.

@JamesNK JamesNK enabled auto-merge (squash) February 10, 2023 02:35
@JamesNK JamesNK merged commit 8e0155c into main Feb 10, 2023
@JamesNK JamesNK deleted the jamesnk/namedpipes-complete branch February 10, 2023 03:13
@ghost ghost added this to the 8.0-preview2 milestone Feb 10, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants