Reduce allocations caused by Range operators on arrays and strings #46519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the Range operator on an array or string causes a new array or string allocation, which may not be necessary. In these cases, we don't need to allocate an intermediate array or string, and can just use a span instead. Fixed minor spelling mistakes in adjacent code.
eerhardt
requested review from
Tratcher,
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
JamesNK
approved these changes
Feb 8, 2023
5 tasks
Tratcher
approved these changes
Feb 8, 2023
eerhardt
commented
Feb 8, 2023
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Range operator on an array or string causes a new array or string allocation, which may not be necessary. In these cases, we don't need to allocate an intermediate array or string, and can just use a span instead.
Fixed minor spelling mistakes in adjacent code.