Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect/unnecessary trimming suppressions. #46518

Merged
merged 4 commits into from
Feb 9, 2023

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Feb 8, 2023

These suppressions weren't not correct. Instead they should be RequiresUnreferencedCode.

These suppressions weren't not correct. Instead they should be RequiresUnreferencedCode.
@eerhardt
Copy link
Member Author

eerhardt commented Feb 9, 2023

@JamesNK - I had to work around a trimmer warning bug, if you want to take a look at the latest commit.

@eerhardt eerhardt requested a review from a team as a code owner February 9, 2023 01:55
@eerhardt eerhardt enabled auto-merge (squash) February 9, 2023 13:31
@eerhardt eerhardt merged commit 105e1b2 into dotnet:main Feb 9, 2023
@ghost ghost added this to the 8.0-preview2 milestone Feb 9, 2023
@eerhardt eerhardt deleted the FixSuppressions branch February 10, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants