-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache and reuse NamedPipeServerStream instances #46473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
Tratcher,
halter73,
BrennanConroy and
mgravell
as code owners
February 6, 2023 10:33
JamesNK
changed the title
Add named pipes microbenchmark
Cache and reuse NamedPipeServerStream instances
Feb 6, 2023
mgravell
reviewed
Feb 6, 2023
src/Servers/Kestrel/Transport.NamedPipes/src/Internal/NamedPipeConnection.cs
Show resolved
Hide resolved
mgravell
reviewed
Feb 6, 2023
src/Servers/Kestrel/Transport.NamedPipes/src/Internal/NamedPipeConnection.cs
Show resolved
Hide resolved
mgravell
reviewed
Feb 6, 2023
src/Servers/Kestrel/Transport.NamedPipes/src/Internal/NamedPipeConnectionListener.cs
Outdated
Show resolved
Hide resolved
mgravell
approved these changes
Feb 6, 2023
gfoidl
reviewed
Feb 6, 2023
src/Servers/Kestrel/Transport.NamedPipes/src/Internal/NamedPipeConnectionListener.cs
Outdated
Show resolved
Hide resolved
mgravell
reviewed
Feb 6, 2023
src/Servers/Kestrel/Transport.NamedPipes/src/Internal/NamedPipeConnectionListener.cs
Show resolved
Hide resolved
BrennanConroy
approved these changes
Feb 6, 2023
src/Servers/Kestrel/Transport.NamedPipes/src/Internal/NamedPipeConnectionListener.cs
Show resolved
Hide resolved
JamesNK
force-pushed
the
jamesnk/cache-namedpipeserverstream
branch
from
February 7, 2023 03:16
ec428e0
to
e78f98c
Compare
ghost
added this to the 8.0-preview2 milestone
Feb 7, 2023
This was referenced Feb 7, 2023
amcasey
added
area-networking
Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
and removed
area-runtime
labels
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-networking
Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NamedPipeServerStream
instances can be reused between connections:This PR adds a cache to the connection listener, allowing streams to be reused between connections.
A further improvement could be to completely reuse
NamedPipeConnection
(the implementation ofConnectionContext
that wraps the stream). However, caching a connection context is harder because it has to determine whether anyone else is still using it.NamedPipeServerStream
is private, making it relatively simple to detect whether it is still in use.Before:
After:
(update) ObjectPool: