Cache and reuse NamedPipeServerStream instances#46473
Merged
Conversation
mgravell
reviewed
Feb 6, 2023
src/Servers/Kestrel/Transport.NamedPipes/src/Internal/NamedPipeConnection.cs
Outdated
Show resolved
Hide resolved
mgravell
reviewed
Feb 6, 2023
src/Servers/Kestrel/Transport.NamedPipes/src/Internal/NamedPipeConnection.cs
Outdated
Show resolved
Hide resolved
mgravell
reviewed
Feb 6, 2023
src/Servers/Kestrel/Transport.NamedPipes/src/Internal/NamedPipeConnectionListener.cs
Outdated
Show resolved
Hide resolved
mgravell
approved these changes
Feb 6, 2023
gfoidl
reviewed
Feb 6, 2023
src/Servers/Kestrel/Transport.NamedPipes/src/Internal/NamedPipeConnectionListener.cs
Outdated
Show resolved
Hide resolved
mgravell
reviewed
Feb 6, 2023
src/Servers/Kestrel/Transport.NamedPipes/src/Internal/NamedPipeConnectionListener.cs
Outdated
Show resolved
Hide resolved
BrennanConroy
approved these changes
Feb 6, 2023
src/Servers/Kestrel/Transport.NamedPipes/src/Internal/NamedPipeConnectionListener.cs
Outdated
Show resolved
Hide resolved
ec428e0 to
e78f98c
Compare
This was referenced Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NamedPipeServerStreaminstances can be reused between connections:This PR adds a cache to the connection listener, allowing streams to be reused between connections.
A further improvement could be to completely reuse
NamedPipeConnection(the implementation ofConnectionContextthat wraps the stream). However, caching a connection context is harder because it has to determine whether anyone else is still using it.NamedPipeServerStreamis private, making it relatively simple to detect whether it is still in use.Before:
After:
(update) ObjectPool: