Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vs install script #4607

Merged
merged 4 commits into from
Dec 12, 2018
Merged

Add Vs install script #4607

merged 4 commits into from
Dec 12, 2018

Conversation

jkotalik
Copy link
Contributor

For https://github.com/aspnet/AspNetCore-Internal/issues/1505.

Didn't bother parsing the korebuild.json file for required components (as they will be removed soon).

Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple tweaks.

Also, can you add mention of this to docs/BuildFromSource.md?

scripts/install_vs.ps1 Outdated Show resolved Hide resolved
scripts/install_vs.ps1 Outdated Show resolved Hide resolved
scripts/install_vs.ps1 Outdated Show resolved Hide resolved
@jkotalik jkotalik closed this Dec 12, 2018
@jkotalik jkotalik reopened this Dec 12, 2018
@jkotalik jkotalik merged commit 7475342 into release/2.1 Dec 12, 2018
@jkotalik jkotalik deleted the jkotalik/scripts branch December 12, 2018 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants