Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Remove legacy check to fix Runtime SiteExtension #46045

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 11, 2023

Backport of #46033 to release/7.0

/cc @BrennanConroy

Remove legacy check to fix Runtime SiteExtension

Summary of the changes (Less than 80 chars)

Description

This package bundles the Runtime and ANCM and then modifies the web.config in App Service to use the bundled versions. A change in infrastructure in 7.0.1 caused the package to no longer bundle the Runtime.

Customer Impact

Azure App Service reported a customer complaining about the 7.0.1 package no longer functioning.

Regression?

  • Yes
  • No

7.0.0 builds set a legacy setting, starting in 7.0.1 the setting was no longer set. Something about arcade changes that removed the legacy variable.

Risk

  • High
  • Medium
  • Low

We were just getting lucky before that a legacy setting was set in our builds that allowed the package to be built correctly. This removes the reliance on the setting, nothing else about the package being built changed.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ghost ghost added the area-runtime label Jan 11, 2023
@BrennanConroy BrennanConroy added the Servicing-consider Shiproom approval is required for the issue label Jan 12, 2023
@BrennanConroy BrennanConroy added this to the 7.0.x milestone Jan 12, 2023
@ghost
Copy link

ghost commented Jan 12, 2023

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@leecow leecow added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jan 12, 2023
@ghost
Copy link

ghost commented Jan 12, 2023

Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@leecow leecow modified the milestones: 7.0.x, 7.0.3 Jan 12, 2023
@dougbu dougbu merged commit 555cc41 into release/7.0 Jan 12, 2023
@dougbu dougbu deleted the backport/pr-46033-to-release/7.0 branch January 12, 2023 20:05
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants