Using JsonTypeInfo to read request body in RDF
#45932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunolins16
added
the
old-area-web-frameworks-do-not-use
ghost
added
the
davidfowl
reviewed
Jan 7, 2023
|
This is a performance optimization, not an AOT work item. RDF has been marked unsafe for linking and AOT. |
davidfowl
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes #45527
Updating RDF to use AOT/linker-safe methods to read the request body as
JSON.Obs.: I decided to not add additional unit/functional test because the current tests cover most part of the behavior already.
Eg.:
aspnetcore/src/Http/Http.Extensions/test/RequestDelegateFactoryTests.cs
Line 1850 in 041a673
aspnetcore/src/Http/Routing/test/FunctionalTests/RouteHandlerTest.cs
Line 22 in 041a673
Waiting for #45593 and #45405