[release/7.0] Fix predicate evaluation in OutputCacheAttribute #45027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Brennan <brecon@microsoft.com>
github-actions
bot
requested review from
Tratcher and
BrennanConroy
as code owners
ghost
added
the
sebastienros
added
the
Servicing-consider
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
halter73
approved these changes
Nov 11, 2022
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@dotnet/aspnet-build PR approved but failing (second time) with the same RestoreTask issue |
adityamandaleeka
added
Servicing-approved
|
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
1 task
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #45013 to release/7.0
/cc @adityamandaleeka @sebastienros
Fix predicate evaluation in OutputCacheAttribute
Description
When using an Output Cache policy that depends on a predicate, the
Defaultpolicy is applied evenif the predicate is false, and the action is still cached.
Fixes #44739
Customer Impact
MVC actions could be cached when not desired.
Regression?
Risk
The change is isolated to the code path with the bug.
Verification
Packaging changes reviewed?