Skip to content

Remove trim attributes from AddEndpointFilter extensions #44738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

davidfowl
Copy link
Member

Not sure why these were marked as trim unsafe.

cc @JamesNK @halter73

@davidfowl davidfowl requested a review from javiercn as a code owner October 26, 2022 06:59
@ghost ghost added the area-runtime label Oct 26, 2022
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If trim analysis is happy, then I'm happy 😄

@davidfowl davidfowl merged commit 4a8a9b4 into main Oct 26, 2022
@davidfowl davidfowl deleted the davidfowl/remove-trim-attributes branch October 26, 2022 15:09
@ghost ghost added this to the 8.0-preview1 milestone Oct 26, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants