Skip to content

Always run inline for socket callbacks #44465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2022
Merged

Always run inline for socket callbacks #44465

merged 1 commit into from
Oct 11, 2022

Conversation

@davidfowl
Copy link
Member

@davidfowl davidfowl commented Oct 11, 2022

  • .NET 8 removed the windows native threadpool fallback for socket IO completions. Remove the checks for flags that no longer exist.

@davidfowl
Always run inline for socket callbacks
11036f0 
- .NET 8 removed the windows native threadpool fallback for socket IO completions. Remove the checks for flags that no longer exist.
@ghost ghost added the area-runtime label Oct 11, 2022
@davidfowl
Copy link
Member Author

davidfowl commented Oct 11, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 11, 2022

Azure Pipelines successfully started running 3 pipeline(s).

This was referenced Oct 11, 2022
Closed
Closed
BrennanConroy
BrennanConroy approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal for reference: dotnet/runtime#71719

@davidfowl davidfowl merged commit e3c3382 into main Oct 11, 2022
@davidfowl davidfowl deleted the davidfowl/remove-winthreadpool-callback branch October 11, 2022 18:13
@ghost ghost added this to the 8.0-preview1 milestone Oct 11, 2022
@build-analysis build-analysis bot mentioned this pull request Oct 11, 2022
Closed
2 tasks
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

8.0-preview1

Development

Successfully merging this pull request may close these issues.

4 participants

@davidfowl @BrennanConroy @amcasey