[6.0] Allow zero byte reads on the test server response body #44020
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YARP adopted the zero-byte-read pattern to reduce memory usage on long lived connections. However, we've found several existing streams in the framework that do not support that pattern.
Description
In-memory web app testing using TestServer is a pattern we recommend to make tests more reliable. Customers can set up YARP to proxy to an in-memory TestServer instance to test multiple applications together. However, when YARP adopted the zero-byte-read pattern, TestServer didn't support that and the scenario broke.
There is no known workaround for 6.0. The issue was partially fixed in 7.0 via new Stream Memory overloads.
Fixes #41692
Customer Impact
YARP customers are currently blocked from testing by proxying to in-memory apps via TestServer.
Regression?
This worked with YARP 1.0 before zero-byte-reads were adopted in 1.1.
Risk
This is a testing component.
Verification
Packaging changes reviewed?