[release/2.1] Remove most non-Windows build job support #43968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- jobs w/ a few explicit settings _may_ run fine but are otherwise unsupported - scripts and so on remain but nothing in our YAML - move the last non-Windows job to Windows - no need for `docker` in `Build SharedFX Installers` job
- log files were lost in failed jobs
- caused problems building SharedFx installers on Windows
ghost
added this to the
|
Hi @dougbu. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Contributor
Author
|
Internal test build #20220912.13 was successful. |
wtgodbe
approved these changes
Sep 14, 2022
Member
wtgodbe
left a comment
wtgodbe
left a comment
There was a problem hiding this comment.
Changes seem good, but I think we should also leave instructions somewhere that say "If you need to turn non-windows 2.1 builds back on, revert these commits"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dockerinBuild SharedFX InstallersjobSharedFX_Installersjob more like the others$(_WorkRoot)