Update developer documentation #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,6 +113,10 @@ On macOS/Linux: | |||
| ./build.sh | |||
| ``` | |||
|
|
|||
| ### Building a subset of the code | |||
|
|
|||
| This repository is large. Look for `build.cmd`/`.sh` scripts in subfolders. These scripts can be used to invoke build and test on a smaller set of projects. | |||
There was a problem hiding this comment.
It looks like most subfolders don't actually have a build.sh/build.cmd file now :/
There was a problem hiding this comment.
Some do. We'll add more in #4247
ryanbrandenburg
approved these changes
Nov 28, 2018
There was a problem hiding this comment.
LGTM other than @BrennanConroy's point, which we definitely need to address somehow.
Tratcher
reviewed
Nov 28, 2018
docs/BuildFromSource.md
Outdated
|
|
||
| 1. Executing the following on command-line: | ||
| ``` | ||
| .\build.cmd /p:SkipTests=true |
There was a problem hiding this comment.
If I drop /p:_ProjectsOnly=true I get 4.7.2 errors in razor:
C:\Users\chrross\.dotnet\x64\sdk\3.0.100-preview-009750\Microsoft.Common.CurrentVersion.targets(1179,5): error MSB3644: The reference assemblies for framework ".NETFramework,Version=v4.7.2" were not found. To resolve this, install the SDK or Targeting Pack for this framework version or retarget your application to a version of the framework for which you have the SDK or Targeting Pack installed. Note that assemblies will be resolved from the Global Assembly Cache (GAC) and will be used in place of reference assemblies. Therefore your assembly may not be correctly targeted for the framework you intend. [D:\github\AspNetCore\modules\Razor\src\Microsoft.CodeAnalysis.Remote.Razor\Microsoft.CodeAnalysis.Remote.Razor.csproj]
C:\Users\chrross\.dotnet\x64\sdk\3.0.100-preview-009750\Microsoft.Common.CurrentVersion.targets(1179,5): error MSB3644: The reference assemblies for framework ".NETFramework,Version=v4.7.2" were not found. To resolve this, install the SDK or Targeting Pack for this framework version or retarget your application to a version of the framework for which you have the SDK or Targeting Pack installed. Note that assemblies will be resolved from the Global Assembly Cache (GAC) and will be used in place of reference assemblies. Therefore your assembly may not be correctly targeted for the framework you intend. [D:\github\AspNetCore\modules\Razor\src\Microsoft.VisualStudio.Editor.Razor\Microsoft.VisualStudio.Editor.Razor.csproj]
C:\Users\chrross\.dotnet\x64\sdk\3.0.100-preview-009750\Microsoft.Common.CurrentVersion.targets(1179,5): error MSB3644: The reference assemblies for framework ".NETFramework,Version=v4.7.2" were not found. To resolve this, install the SDK or Targeting Pack for this framework version or retarget your application to a version of the framework for which you have the SDK or Targeting Pack installed. Note that assemblies will be resolved from the Global Assembly Cache (GAC) and will be used in place of reference assemblies. Therefore your assembly may not be correctly targeted for the framework you intend. [D:\github\AspNetCore\modules\Razor\src\Microsoft.VisualStudio.Mac.LanguageServices.Razor\Microsoft.VisualStudio.Mac.LanguageServices.Razor.csproj]
C:\Users\chrross\.dotnet\x64\sdk\3.0.100-preview-009750\Microsoft.Common.CurrentVersion.targets(1179,5): error MSB3644: The reference assemblies for framework ".NETFramework,Version=v4.7.2" were not found. To resolve this, install the SDK or Targeting Pack for this framework version or retarget your application to a version of the framework for which you have the SDK or Targeting Pack installed. Note that assemblies will be resolved from the Global Assembly Cache (GAC) and will be used in place of reference assemblies. Therefore your assembly may not be correctly targeted for the framework you intend. [D:\github\AspNetCore\modules\Razor\src\Microsoft.VisualStudio.LanguageServices.Razor\Microsoft.VisualStudio.LanguageServices.Razor.csproj]
There was a problem hiding this comment.
Hmm. I'll put /p:_ProjectsOnly=true back in the instructions for now. I thought we had a PackageRef to netfx 4.7.2, but apparently that doesn't work...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more details for commonly asked questions, known issues, and some tips on being productive in aspnet/AspNetCore.