Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Blazor WASM Auth Tests to New Project #42879

Merged
merged 6 commits into from
Aug 1, 2022
Merged

Split Blazor WASM Auth Tests to New Project #42879

merged 6 commits into from
Aug 1, 2022

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Jul 22, 2022 •
edited
Loading

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 22, 2022
@TanayParikh TanayParikh mentioned this pull request Jul 22, 2022
Closed
@TanayParikh TanayParikh self-assigned this Jul 22, 2022
@TanayParikh TanayParikh added this to the 7.0-rc1 milestone Jul 22, 2022
@TanayParikh TanayParikh marked this pull request as ready for review July 25, 2022 20:02
@TanayParikh TanayParikh requested a review from Pilchie as a code owner July 25, 2022 20:02
@TanayParikh TanayParikh requested review from a team and removed request for Pilchie July 25, 2022 20:02
TanayParikh
TanayParikh commented Jul 25, 2022
View reviewed changes
...tTemplates/test/Templates.Blazor.WebAssembly.Tests/Templates.Blazor.WebAssembly.Tests.csproj
@@ -6,7 +6,6 @@
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
<TestGroupName>ProjectTemplates.Blazor.WebAssembly.Tests</TestGroupName>
<DefineConstants>$(DefineConstants);XPLAT</DefineConstants>
<HelixTimeout>01:00:00</HelixTimeout>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This increased timeout was recently introduced due to these tests timing out. With this split, this should no longer be required.

@TanayParikh TanayParikh merged commit 9f7dfd9 into main Aug 1, 2022
@TanayParikh TanayParikh deleted the taparik/splitBlazorWasmAuthTests branch August 1, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

Assignees

@TanayParikh TanayParikh

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
7.0-rc1
Development

Successfully merging this pull request may close these issues.

Blazor WASM Template tests are too long
2 participants
@TanayParikh @javiercn