Mark SignalR SourceGen as not shipping for RC and RTM #42720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
reviewed
Jul 21, 2022
| public static string SourceFilePrefix() | ||
| { | ||
| return @"// <auto-generated> | ||
| // Generated by Microsoft.AspNetCore.Client.SourceGenerator |
There was a problem hiding this comment.
What do you think about adding the assembly file version to the header? e.g.
Generated by Microsoft.AspNetCore.Client.SourceGenerator 7.0.22.35609
Makes it easier to see at a glance what version of the generator ran.
There was a problem hiding this comment.
This is what comes from the AssemblyInfo generator:
//------------------------------------------------------------------------------
// <auto-generated>
// This code was generated by a tool.
// Runtime Version:4.0.30319.42000
//
// Changes to this file may cause incorrect behavior and will be lost if
// the code is regenerated.
// </auto-generated>
//------------------------------------------------------------------------------
There was a problem hiding this comment.
Sounds like a good addition once we start shipping this package.
halter73
approved these changes
Aug 4, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SignalR client source generator work isn't RC/RTM ready yet. Marking it as non-shipping for RC/RTM.
Copied a bug fix and some formatting changes from #38025 as well.