Skip to content

Run tests on Windows again #41599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2022
Merged

Run tests on Windows again #41599

merged 5 commits into from
May 10, 2022

Conversation

BrennanConroy
Copy link
Member

Windows tests stopped running after #41311. Also, the RunHelix script was broken at the same time.

@BrennanConroy BrennanConroy requested review from a team, dougbu and wtgodbe as code owners May 10, 2022 00:35
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 10, 2022
@@ -59,4 +59,4 @@ $HelixQueues = $HelixQueues -replace ";", "%3B"
dotnet msbuild $Project /t:Helix /p:TargetArchitecture="$TargetArchitecture" `
/p:HelixTargetQueues=$HelixQueues /p:RunQuarantinedTests=$RunQuarantinedTests `
/p:_UseHelixOpenQueues=true /p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log `
/p:DoNotRequireSharedFxHelix=true @MSBuildArguments
/p:DoNotRequireSharedFxHelix=true /p:NUGET_PACKAGES=$env:HOMEPATH/.nuget/packages/ @MSBuildArguments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, I remember thinking about using a fallback but must have forgotten 🤦

@wtgodbe
Copy link
Member

wtgodbe commented May 10, 2022

Now we've got a real failure in Templates.Test.MvcTemplateTest.MvcTemplate_SingleFileExe

Project new mvc  failed to publish. Exit code -1.
dotnet publish  -c Release /bl /p:PublishSingleFile=true -r win-x64
StdErr:
StdOut: Microsoft (R) Build Engine version 17.3.0-preview-22254-01+e049bfe3d for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

C:hwA804099Apdotnet-clisdk7.0.100-preview.5.22258.1MSBuild.dll -maxcpucount -property:PublishSingleFile=true -property:RuntimeIdentifier=win-x64 -property:_CommandLineDefinedRuntimeIdentifier=true -property:Configuration=Release -restore -target:Publish -verbosity:m /bl .AspNet.rsujqrthdeb.csproj
Determining projects to restore...
Restored C:hwA804099AwA31A093CeTemplatesBaseFolderAspNet.rsujqrthdebAspNet.rsujqrthdeb.csproj (in 6.95 sec).
C:hwA804099Apdotnet-clisdk7.0.100-preview.5.22258.1SdksMicrosoft.NET.Sdk	argetsMicrosoft.NET.RuntimeIdentifierInference.targets(216,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:hwA804099AwA31A093CeTemplatesBaseFolderAspNet.rsujqrthdebAspNet.rsujqrthdeb.csproj]
C:hwA804099Apdotnet-clisdk7.0.100-preview.5.22258.1SdksMicrosoft.NET.Sdk	argetsMicrosoft.NET.Sdk.targets(1117,5): warning NETSDK1179: One of '--self-contained' or '--no-self-contained' options are required when '--runtime' is used. [C:hwA804099AwA31A093CeTemplatesBaseFolderAspNet.rsujqrthdebAspNet.rsujqrthdeb.csproj]
AspNet.rsujqrthdeb -> C:hwA804099AwA31A093CeTemplatesBaseFolderAspNet.rsujqrthdeb�inRelease
et7.0win-x64AspNet.rsujqrthdeb.dll
AspNet.rsujqrthdeb -> C:hwA804099AwA31A093CeTemplatesBaseFolderAspNet.rsujqrthdeb�inRelease
et7.0win-x64publish

Expected: True
Actual:   False

at Templates.Test.MvcTemplateTest.MvcTemplate_SingleFileExe() in /_/src/ProjectTemplates/test/MvcTemplateTest.cs:line 252

Quarantine? Or update the test to resolve warning NETSDK1179: One of '--self-contained' or '--no-self-contained' options are required when '--runtime' is used. CC @captainsafia @DamianEdwards

@captainsafia
Copy link
Member

update the test to resolve warning NETSDK1179: One of '--self-contained' or '--no-self-contained' options are required when '--runtime' is used.

I believe we need to update the test to resolve the warning. That's what @DamianEdwards attempted in #41563.

@BrennanConroy BrennanConroy requested a review from Pilchie as a code owner May 10, 2022 16:44
@BrennanConroy BrennanConroy merged commit af9c8d9 into main May 10, 2022
@BrennanConroy BrennanConroy deleted the brecon/fixWindows branch May 10, 2022 23:10
@ghost ghost added this to the 7.0-preview5 milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants