-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Run tests on Windows again #41599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on Windows again #41599
Conversation
@@ -59,4 +59,4 @@ $HelixQueues = $HelixQueues -replace ";", "%3B" | |||
dotnet msbuild $Project /t:Helix /p:TargetArchitecture="$TargetArchitecture" ` | |||
/p:HelixTargetQueues=$HelixQueues /p:RunQuarantinedTests=$RunQuarantinedTests ` | |||
/p:_UseHelixOpenQueues=true /p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log ` | |||
/p:DoNotRequireSharedFxHelix=true @MSBuildArguments | |||
/p:DoNotRequireSharedFxHelix=true /p:NUGET_PACKAGES=$env:HOMEPATH/.nuget/packages/ @MSBuildArguments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, I remember thinking about using a fallback but must have forgotten 🤦
Now we've got a real failure in
Quarantine? Or update the test to resolve |
I believe we need to update the test to resolve the warning. That's what @DamianEdwards attempted in #41563. |
Windows tests stopped running after #41311. Also, the RunHelix script was broken at the same time.