Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix Restore Issue Mitigation #41311

Merged
merged 27 commits into from
Apr 30, 2022
Merged

Helix Restore Issue Mitigation #41311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
021516b
RunTests dotnet run --no-build
TanayParikh Apr 21, 2022
ee6202c
Remove duplicate run
TanayParikh Apr 21, 2022
674d5b9
Add to Build.props
TanayParikh Apr 21, 2022
85c3d69
Treat CA2007 as a warning in RunTests
TanayParikh Apr 21, 2022
133ce0b
NoWarn CA2007
TanayParikh Apr 21, 2022
4a6ba96
Ignore NU5104 for System.CommandLine prerelease package
TanayParikh Apr 21, 2022
69e1468
PR Feedback
TanayParikh Apr 21, 2022
3f97899
PR Feedback
TanayParikh Apr 22, 2022
f5d847e
Generate .config/dotnet-tools.json
dougbu Apr 27, 2022
56bacbe
Add tool packages to Helix correlation payloads
dougbu Apr 27, 2022
95a90e5
Do not restore tools from network
dougbu Apr 27, 2022
0f97390
Do not pass `dotnet-ef` version to `RunTests`
dougbu Apr 27, 2022
9a2900d
Remove DotNetToolsInstaller.csproj
dougbu Apr 27, 2022
787b743
Add `--playwright` option in `Runtests`
dougbu Apr 28, 2022
3664794
Use Arcade SDK in `RunTests` and `Publish` project
dougbu Apr 28, 2022
f550234
Correct minor problems in `RunTests` source
dougbu Apr 28, 2022
ac9b2f8
Use file-scoped namespaces in `RunTests` source
dougbu Apr 28, 2022
d9ef4d8
Use VS code fixes in `RunTests`
dougbu Apr 28, 2022
c12501c
Use published `RunTests` output on Helix agents
dougbu Apr 28, 2022
ddc91e0
Move `RunTests` under eng/tools/
dougbu Apr 28, 2022
9961ccb
Add `RunTests` to tools.slnf
dougbu Apr 28, 2022
5b14ca6
Rename `RunTests` project to `HelixTestRunner`
dougbu Apr 29, 2022
b3e15e0
!fixup! Define `$(ArtifactsBinDir)` in helix.proj
dougbu Apr 29, 2022
a788fd6
!fixup! Use `$(Configuration)` in helix.proj
dougbu Apr 29, 2022
9e45752
!fixup! Fix typo in property function
dougbu Apr 29, 2022
a22be2b
!fixup! Fix `dotnet` syntax in runtests.sh
dougbu Apr 29, 2022
9ffdffb
!fixup! Correct `%(HelixCorrelationPayload.Destination)`
dougbu Apr 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correct minor problems in RunTests source
  • Loading branch information
@dougbu
dougbu committed Apr 29, 2022
commit f55023415adacaf88ae9059a4b375d79bc2f5cec
1 change: 0 additions & 1 deletion eng/helix/content/RunTests/ProcessResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

namespace RunTests
{
Expand Down
2 changes: 0 additions & 2 deletions eng/helix/content/RunTests/ProcessUtil.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System;
using System.Collections.Generic;
Expand Down Expand Up @@ -95,7 +94,6 @@ public static async Task<ProcessResult> RunAsync(
EnableRaisingEvents = true
};


if (workingDirectory != null)
{
process.StartInfo.WorkingDirectory = workingDirectory;
Expand Down