Skip to content

Don't invert bool template option for UseProgramMain in Visual Studio #40937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

DamianEdwards
Copy link
Member

Fixes #40917

@DamianEdwards DamianEdwards requested review from a team and Pilchie as code owners March 29, 2022 17:47
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 29, 2022
@phenning
Copy link
Contributor

@DamianEdwards before merging, we should make sure that the UI strings for display name and description for the new parameter are consistent between aspnet core and console.

@DamianEdwards
Copy link
Member Author

@phenning good call, it appears to be "Do not use top-level statements" over there. Happy to go with that.

@phenning
Copy link
Contributor

LGTM :shipit:

@DamianEdwards DamianEdwards enabled auto-merge (squash) March 29, 2022 20:25
@DamianEdwards DamianEdwards merged commit 38ef2c9 into main Mar 29, 2022
@DamianEdwards DamianEdwards deleted the damianedwards/UseProgramMain-VS-option branch March 29, 2022 23:51
@ghost ghost added this to the 7.0-preview3 milestone Mar 29, 2022
@dougbu dougbu modified the milestones: 7.0-preview3, 7.0-preview4 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't invert the UseProgramMain option in project templates in Visual Studio
3 participants