Skip to content

HttpLoggingMiddleware + Websockets/Upgrade #40841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 25, 2022
Merged

HttpLoggingMiddleware + Websockets/Upgrade #40841

merged 16 commits into from
Mar 25, 2022

Conversation

gfr-g
Copy link
Contributor

@gfr-g gfr-g commented Mar 23, 2022 •
edited
Loading

HttpLoggingMiddleware + Websockets/Upgrade #31962

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

HttpLoggingMiddleware now logs response headers following an upgrade connection request as soon as the response is sent to the client.

Description

A new decorator around the IHttpUpgradeFeature has been introduced in the HttpLoggingMiddleware in order to log the response headers while the middleware pipeline is still running due to the connection being upgraded.

Fixes #31962

@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Mar 23, 2022
@dnfadmin
Copy link

dnfadmin commented Mar 23, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@BrennanConroy BrennanConroy requested a review from wtgodbe March 23, 2022 17:36
Tratcher
Tratcher reviewed Mar 24, 2022
View reviewed changes
@BrennanConroy BrennanConroy changed the title Issue/31962 HttpLoggingMiddleware + Websockets/Upgrade Mar 25, 2022
@gfr-g gfr-g requested a review from Tratcher March 25, 2022 16:59
Tratcher
Tratcher approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @wtgodbe take a look also.

@gfr-g @Tratcher
Removed redundant check
ed3233a 
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
wtgodbe
wtgodbe reviewed Mar 25, 2022
View reviewed changes
wtgodbe
wtgodbe reviewed Mar 25, 2022
View reviewed changes
@gfr-g gfr-g requested a review from halter73 as a code owner March 25, 2022 18:31
@Tratcher Tratcher enabled auto-merge (squash) March 25, 2022 18:41
@Tratcher Tratcher added this to the 7.0-preview4 milestone Mar 25, 2022
@Tratcher Tratcher merged commit 5a5b2e2 into dotnet:main Mar 25, 2022
@ghost ghost modified the milestones: 7.0-preview4, 7.0-preview3 Mar 25, 2022
@Tratcher
Copy link
Member

Thanks

@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73

Assignees

@Tratcher Tratcher

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
7.0-preview4
Development

Successfully merging this pull request may close these issues.

HttpLoggingMiddleware + Websockets/Upgrade
7 participants
@gfr-g @dnfadmin @Tratcher @wtgodbe @adityamandaleeka @BrennanConroy @amcasey