[Blazor] Fix race condition when caching for a type of QueryParameterValueSupplier (#40636) #40663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ValueSupplier (#40636) * Use a concurrent dictionary to avoid race conditions.
ghost
added
the
|
Hi @javiercn. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
javiercn
added
the
ask-mode
SteveSandersonMS
approved these changes
Mar 11, 2022
javiercn
added
Servicing-consider
|
Hi @javiercn. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
mkArtakMSFT
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were using a regular dictionary on an internal cache that can be accessed concurrently.
#40595
Customer Impact
If two or more threads try to populate the cache concurrently, it can cause the app to fail.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
It's switching the underlying dictionary type used.
Verification
We have extensive E2E and unit tests for this behavior.
Packaging changes reviewed?