Skip to content

[release/5.0] Update url-parse component #40586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2022
Merged

[release/5.0] Update url-parse component #40586

merged 1 commit into from
Mar 8, 2022

Conversation

@dougbu
Copy link
Contributor

@dougbu dougbu commented Mar 8, 2022

  • address CG bugs w/ older versions

@dougbu
[release/5.0] Update url-parse component
a886ed2 
- address CG bugs w/ older versions
@ghost ghost added this to the 5.0.x milestone Mar 8, 2022
@ghost
Copy link

ghost commented Mar 8, 2022

Hi @dougbu. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@dougbu
Copy link
Contributor Author

dougbu commented Mar 8, 2022

/cc @dotnet/aspnet-build

@TanayParikh
Copy link
Contributor

TanayParikh commented Mar 8, 2022

Looks like the CI isn't happy with these changes.

@dougbu
Copy link
Contributor Author

dougbu commented Mar 8, 2022

Looks like the CI isn't happy with these changes.

CI is pointing to an environment variable set in src\SignalR\clients\ts\FunctionalTests\scripts\run-tests.ts. I'm hoping we can just remove that. Asked @BrennanConroy and @halter73 about it in Teams…

@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Mar 8, 2022
@dougbu dougbu merged commit 34389d1 into dotnet:release/5.0 Mar 8, 2022
@dougbu dougbu deleted the dougbu/components/5.0 branch March 8, 2022 18:32
@dougbu dougbu modified the milestones: 5.0.x, 5.0.16 Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS SteveSandersonMS is a code owner

+1 more reviewer

@TanayParikh TanayParikh TanayParikh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

5.0.16

Development

Successfully merging this pull request may close these issues.

3 participants

@dougbu @TanayParikh @wtgodbe