Use WixBundleName instead of WixBundle #40305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
Member
Author
|
Grabbing installers from this test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1621242&view=results |
joeloff
approved these changes
Feb 18, 2022
dougbu
approved these changes
Feb 19, 2022
Member
Author
|
|
Member
Author
|
/backport to release/6.0 |
Member
Author
|
/backport to release/5.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1882897421 |
Member
Author
|
/backport to release/3.1 |
Contributor
|
Started backporting to release/5.0: https://github.com/dotnet/aspnetcore/actions/runs/1882898386 |
Contributor
|
Started backporting to release/3.1: https://github.com/dotnet/aspnetcore/actions/runs/1882899799 |
This was referenced Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The predefined variable is named
WixBundleName, but we've been usingWixBundlein the SharedFx, which causes its installer to have the text "Welcome to the setup"https://wixtoolset.org/documentation/manual/v3/bundle/bundle_built_in_variables.html
