[release/5.0] Resolve Component Governance bugs #40218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
requested review from
a team,
BrennanConroy,
SteveSandersonMS and
halter73
as code owners
ghost
added this to the
|
Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
wtgodbe
added
area-infrastructure
dougbu
reviewed
Feb 15, 2022
Member
|
👀 |
dougbu
reviewed
Feb 15, 2022
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Looks fine but please don't merge w/o signoff from someone deeper in our node, npm / yarn world.
| displayName: Install Node 14.x | ||
| inputs: | ||
| versionSpec: 10.x | ||
| versionSpec: 14.x |
Contributor
There was a problem hiding this comment.
Should we jump all the way forward to 16.x and catch up w/ 'main'❔ Thoughts @javiercn @BrennanConroy…
Member
Author
There was a problem hiding this comment.
I did this to match 6.0:
aspnetcore/.azure/pipelines/jobs/default-build.yml
Lines 169 to 173 in d5d2e4d
dougbu
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #37889. Resolves the remaining High/Critical 5.0 CompGov bug(s)