BuildIisNativeProjects -> UseIisNativeAssets

[HaoK]

Fixes #39654

Clarifies what this property actually does

[sebastienros]

IIS native projects can only be built on Windows, but also they are always built on Windows. When can this property be false on Windows? I currently set it when I build Kestrel for instance, even from a fresh clone. Can some project build.cmd files set it to false safely?

[HaoK]

I believe you can just pass in -noBuildNative if you explicitly want to skip native code building as that turns off. But hence the rename here, there's a bunch of projects that need to update iis native assets which is why we are renaming this to something not called build

[HaoK]

Basically projects that want to pull in ancm will have this set, and if you don't have ancm built, when it tries to update/include it, it will fail, as it should

[dougbu]

-noBuildNative won't change most of what the property does. That switch only controls whether a native (desktop) msbuild happens if you use one of our build.cmd or build.ps1 scripts.
The $(BuildNative) property reflect that choice while we're building but only when building using desktop msbuild and mainly to distinguish the scenario from -buildInstallers / $(BuildInstallers) (the other case where we build using desktop msbuild).

[wtgodbe]

Looks like you missed a couple?

[HaoK]

@wtgodbe can you point to the ones you saw that I missed? main is failing due to a bad PR pranav merged, so the checks will be red until that's fixed

[dougbu]

Not sure I understand the word "update" in this context though I agree Build isn't correct much of the time. I suggest picking another word to start the name.

The property does a bunch of stuff. Mostly it

• controls whether managed projects use (pack, copy around, …) native assemblies built in an earlier eng/build.ps1 phase or separate -buildNative build
• controls how Microsoft.AspNetCore.App.Runtime brings in aspnetcorev2_inprocess.dll when that project is built using desktop msbuild or dotnet msbuild (a corner case but a supported one)

[dougbu]

-noBuildNative won't change most of what the property does. That switch only controls whether a native (desktop) msbuild happens if you use one of our build.cmd or build.ps1 scripts.
The $(BuildNative) property reflect that choice while we're building but only when building using desktop msbuild and mainly to distinguish the scenario from -buildInstallers / $(BuildInstallers) (the other case where we build using desktop msbuild).

[HaoK]

Unless you have a specific suggestion @dougbu I'm going to stick with update since the main motivation was just to move away from build since its not even really building the native bits, update conveys the notion that its trying to 'update' ancm/native bits, that's the idea anyways. Happy to switch it to something better if you have any ideas, given that this isn't something we are going to set/use, just untangling this from build seems good enough

[wtgodbe]

@wtgodbe can you point to the ones you saw that I missed? main is failing due to a bad PR pranav merged, so the checks will be red until that's fixed

Ah, in that case this looks fine to me

[dougbu]

Unless you have a specific suggestion @dougbu I'm going to stick with update since the main motivation was just to move away from build since its not even really building the native bits, update conveys the notion that its trying to 'update' ancm/native bits

My suggestion would be "Use…` since it doesn't change ("update") the native bits at all. "Pack…" would also make sense but may be too specific.

[HaoK]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[HaoK]

Okay so UpdateIisNativeAssets -> UseIisNativeAssets

[HaoK]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).