Skip to content

Backport Use CDN for .NET Assets for release/5.0 #39044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 17, 2021
Merged

Backport Use CDN for .NET Assets for release/5.0 #39044

merged 3 commits into from
Dec 17, 2021

Conversation

@TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Dec 15, 2021

@TanayParikh TanayParikh requested a review from dougbu as a code owner December 15, 2021 00:44
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Dec 15, 2021
@ghost ghost added this to the 5.0.x milestone Dec 15, 2021
@ghost
Copy link

ghost commented Dec 15, 2021

Hi @TanayParikh. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@TanayParikh TanayParikh requested a review from a team December 15, 2021 00:45
@TanayParikh TanayParikh added the tell-mode Indicates a PR which is being merged during tell-mode label Dec 15, 2021
@TanayParikh TanayParikh mentioned this pull request Dec 15, 2021
Merged
@dougbu
Copy link
Contributor

dougbu commented Dec 15, 2021

@MattGal does the CDN update also not apply for release/5.0❔

Problems downloading file from 'https://dotnetbuilds.azureedge.net/public/Runtime/5.0.12-servicing.21522.7/dotnet-runtime-5.0.12-linux-arm.tar.gz'. Does the resource exist on the storage? NotFound

@MattGal
Copy link
Member

MattGal commented Dec 15, 2021

@MattGal does the CDN update also not apply for release/5.0❔

Problems downloading file from 'https://dotnetbuilds.azureedge.net/public/Runtime/5.0.12-servicing.21522.7/dotnet-runtime-5.0.12-linux-arm.tar.gz'. Does the resource exist on the storage? NotFound

As noted on the other one, the change isn't present for publishing before 6.x, but you can still switch to azureedge.net for dotnetcli and get the same benefit from the other CDN.

@TanayParikh
Copy link
Contributor Author

TanayParikh commented Dec 15, 2021

Not working with dotnetcli.azureedge.net either, leaving as is.

@TanayParikh TanayParikh deleted the TanayParikh-patch-2 branch December 15, 2021 18:00
@dougbu dougbu removed this from the 5.0.x milestone Dec 15, 2021
@TanayParikh TanayParikh restored the TanayParikh-patch-2 branch December 16, 2021 22:16
@TanayParikh TanayParikh reopened this Dec 16, 2021
@TanayParikh
Copy link
Contributor Author

TanayParikh commented Dec 17, 2021

@dotnet/aspnet-build requesting merge please.

@dougbu dougbu merged commit a92e017 into release/5.0 Dec 17, 2021
@dougbu dougbu deleted the TanayParikh-patch-2 branch December 17, 2021 01:56
@dougbu dougbu added this to the 5.0.14 milestone Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

5.0.14

Development

Successfully merging this pull request may close these issues.

4 participants

@TanayParikh @dougbu @MattGal