Remove unnecessary unicode control characters #38900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://trojansource.codes/ demonstrated that unicode control characters could be used in attacks. Now most IDEs, editors and code browsers (including GitHub) warn about these. Delete these from source to remove a source of confusion for anyone going through this code. The characters were introduced by dotnet#32245 and you can see an example of the warnings shown by GitHub here: https://github.com/dotnet/aspnetcore/blob/69308dafeda51d5301396c88ba9136a6da97c7b6/src/Http/Http/src/Features/FormOptions.cs
omajid
requested review from
BrennanConroy,
halter73 and
Tratcher
as code owners
ghost
added
area-runtime
community-contribution
Tratcher
approved these changes
Dec 8, 2021
|
Thanks |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trojansource.codes/ demonstrated that unicode control characters could be used in attacks. Now most IDEs, editors and code browsers (including GitHub) warn about these.
Delete these from source to remove a source of confusion for anyone going through this code.
The characters were introduced by #32245 and you can see an
example of the warnings shown by GitHub here: https://github.com/dotnet/aspnetcore/blob/69308dafeda51d5301396c88ba9136a6da97c7b6/src/Http/Http/src/Features/FormOptions.cs