Skip to content

HTTP/3: Remove request-only headers from enumerator #38610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2021
Merged

HTTP/3: Remove request-only headers from enumerator #38610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Servers/Kestrel/Core/src/Internal/Http2/Http2HeadersEnumerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ public void Dispose()

internal static int GetResponseHeaderStaticTableId(KnownHeaderType responseHeaderType)
{
// Removed from this test are request-only headers, e.g. cookie.
switch (responseHeaderType)
{
case KnownHeaderType.CacheControl:
Expand Down
30 changes: 2 additions & 28 deletions src/Servers/Kestrel/Core/src/Internal/Http3/Http3HeadersEnumerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,8 @@ public void Dispose()

internal static int GetResponseHeaderStaticTableId(KnownHeaderType responseHeaderType)
{
// Removed from this test are request-only headers, e.g. cookie.
//
// Not every header in the QPACK static table is known.
// These are missing from this test and the full header name is written.
// Missing:
Expand All @@ -171,28 +173,14 @@ internal static int GetResponseHeaderStaticTableId(KnownHeaderType responseHeade
return H3StaticTable.ContentLength0;
case KnownHeaderType.Date:
return H3StaticTable.Date;
case KnownHeaderType.Cookie:
return H3StaticTable.Cookie;
case KnownHeaderType.ETag:
return H3StaticTable.ETag;
case KnownHeaderType.IfModifiedSince:
return H3StaticTable.IfModifiedSince;
case KnownHeaderType.IfNoneMatch:
return H3StaticTable.IfNoneMatch;
case KnownHeaderType.LastModified:
return H3StaticTable.LastModified;
case KnownHeaderType.Location:
return H3StaticTable.Location;
case KnownHeaderType.Referer:
return H3StaticTable.Referer;
case KnownHeaderType.SetCookie:
return H3StaticTable.SetCookie;
case KnownHeaderType.Method:
return H3StaticTable.MethodConnect;
case KnownHeaderType.Accept:
return H3StaticTable.AcceptAny;
case KnownHeaderType.AcceptEncoding:
return H3StaticTable.AcceptEncodingGzipDeflateBr;
case KnownHeaderType.AcceptRanges:
return H3StaticTable.AcceptRangesBytes;
case KnownHeaderType.AccessControlAllowHeaders:
Expand All @@ -205,30 +193,16 @@ internal static int GetResponseHeaderStaticTableId(KnownHeaderType responseHeade
return H3StaticTable.ContentEncodingBr;
case KnownHeaderType.ContentType:
return H3StaticTable.ContentTypeApplicationDnsMessage;
case KnownHeaderType.Range:
return H3StaticTable.RangeBytes0ToAll;
case KnownHeaderType.Vary:
return H3StaticTable.VaryAcceptEncoding;
case KnownHeaderType.AcceptLanguage:
return H3StaticTable.AcceptLanguage;
case KnownHeaderType.AccessControlAllowCredentials:
return H3StaticTable.AccessControlAllowCredentials;
case KnownHeaderType.AccessControlAllowMethods:
return H3StaticTable.AccessControlAllowMethodsGet;
case KnownHeaderType.AltSvc:
return H3StaticTable.AltSvcClear;
case KnownHeaderType.Authorization:
return H3StaticTable.Authorization;
case KnownHeaderType.IfRange:
return H3StaticTable.IfRange;
case KnownHeaderType.Origin:
return H3StaticTable.Origin;
case KnownHeaderType.Server:
return H3StaticTable.Server;
case KnownHeaderType.UpgradeInsecureRequests:
return H3StaticTable.UpgradeInsecureRequests1;
case KnownHeaderType.UserAgent:
return H3StaticTable.UserAgent;
default:
return -1;
}
Expand Down