[release/6.0] Use window.document for React-Native #38598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #38340 to release/6.0
/cc @BrennanConroy
Use window.document for React-Native
Description
When using React-Native on an Android/iOS device you will see an error when trying to connect:
ReferenceError: Can't find variable: document'. This is because our check for using thedocumentvariable didn't properly handle environments like React-Native where awindowexists butdocumentdoesn't.Fixes #38286
Customer Impact
The SignalR TypeScript library is not usable when upgrading to 6.0 when using React-Native.
I did come up with a workaround that is non-obvious to unblock customers:
Regression?
Regression from 5.0 to 6.0
Risk
Scope of change is small. Made platform checks more robust to avoid unexpected failures when using different frameworks.
Verification
Packaging changes reviewed?