Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSBuild property name for Microsoft.Build.Tasks.Core #37404

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Oct 8, 2021

There was a missing 's', which caused source-build to use a pre-built when building.

Related to dotnet/source-build#2412

There was a missing 's', which caused source-build to use a pre-built when building.
Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should this target release/6.0 instead?

@eerhardt
Copy link
Member Author

eerhardt commented Oct 8, 2021

Should this target release/6.0 instead?

My understanding is that aspnetcore works like runtime. The process is get a change into main first, make sure it is stable, then port to the release branch.

@dougbu dougbu enabled auto-merge (squash) October 8, 2021 19:42
@dougbu
Copy link
Member

dougbu commented Oct 8, 2021

/fyi I enabled auto-squish for this PR

@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 8, 2021
@dougbu
Copy link
Member

dougbu commented Oct 8, 2021

How necessary and urgent in 'release/6.0' is this fix @eerhardt @dseefeld @MichaelSimons❔ And, are we peeling an onion here or is this likely the last source-build fix needed❔

Suggest tell-mode if we do this in 'release/6.0'. Agree @Pilchie

@Pilchie
Copy link
Member

Pilchie commented Oct 8, 2021

Yes, tell-mode is fine for 6.0.

@MichaelSimons
Copy link
Member

How necessary and urgent in 'release/6.0' is this fix

This is required for .NET 6.0.

are we peeling an onion here?

Yes, we know there are a number of prebuilts in aspnetcore right now (3 direct and 9 indirect). We are still investigating and it is unknown how many will require aspnetcore source changes.

@dougbu
Copy link
Member

dougbu commented Oct 8, 2021

Alright. Nothing here will break non-source-build builds and we might as well move through the onion incrementally. @dotnet/aspnet-build if any of you have had success using the backport action, please do the needful here.

@dougbu dougbu merged commit 8b09560 into dotnet:main Oct 8, 2021
dougbu pushed a commit to dougbu/aspnetcore that referenced this pull request Oct 8, 2021
…rsion

- backport of dotnet#37404, cherry-pick of 8b09560

Fix MSBuild property name for MicrosoftBuildTasksCoreVersion (dotnet#37404)

  * There was a missing 's', which caused source-build to use a pre-built when building.
dougbu added a commit that referenced this pull request Oct 9, 2021
…rsion (#37411)

- backport of #37404, cherry-pick of 8b09560

Fix MSBuild property name for MicrosoftBuildTasksCoreVersion (#37404)

  * There was a missing 's', which caused source-build to use a pre-built when building.

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
@eerhardt eerhardt deleted the FixMSBuildPropName branch October 9, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants