-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MSBuild property name for Microsoft.Build.Tasks.Core #37404
Conversation
There was a missing 's', which caused source-build to use a pre-built when building.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should this target release/6.0 instead?
My understanding is that aspnetcore works like runtime. The process is get a change into |
/fyi I enabled auto-squish for this PR |
How necessary and urgent in 'release/6.0' is this fix @eerhardt @dseefeld @MichaelSimons❔ And, are we peeling an onion here or is this likely the last source-build fix needed❔ Suggest |
Yes, tell-mode is fine for 6.0. |
This is required for .NET 6.0.
Yes, we know there are a number of prebuilts in aspnetcore right now (3 direct and 9 indirect). We are still investigating and it is unknown how many will require aspnetcore source changes. |
Alright. Nothing here will break non-source-build builds and we might as well move through the onion incrementally. |
…rsion - backport of dotnet#37404, cherry-pick of 8b09560 Fix MSBuild property name for MicrosoftBuildTasksCoreVersion (dotnet#37404) * There was a missing 's', which caused source-build to use a pre-built when building.
There was a missing 's', which caused source-build to use a pre-built when building.
Related to dotnet/source-build#2412