Skip to content

PersonalDataAttribute should only apply to properties #36067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2021
Merged

PersonalDataAttribute should only apply to properties #36067

merged 1 commit into from
Sep 2, 2021

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Sep 1, 2021

Fixes #32833

@ghost ghost added the area-identity Includes: Identity and providers label Sep 1, 2021
@HaoK HaoK requested a review from Tratcher September 2, 2021 04:12
@HaoK HaoK marked this pull request as ready for review September 2, 2021 04:12
@HaoK HaoK requested a review from Pilchie as a code owner September 2, 2021 04:12
Tratcher
Tratcher approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only be for 7, right?

@Tratcher Tratcher added the breaking-change This issue / pr will introduce a breaking change, when resolved / merged. label Sep 2, 2021
@HaoK
Copy link
Member Author

HaoK commented Sep 2, 2021

Yup, only 7

@HaoK HaoK merged commit 9584881 into main Sep 2, 2021
@HaoK HaoK deleted the HaoK/attr branch September 2, 2021 16:02
@ghost ghost added this to the 7.0-preview1 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-identity Includes: Identity and providers breaking-change This issue / pr will introduce a breaking change, when resolved / merged.
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.

PersonalDataAttribute does not specify AttributeUsage.
2 participants
@HaoK @Tratcher