Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Serializing Return Values for InvokeVoidAsync #35807

Merged
merged 14 commits into from
Aug 31, 2021
Merged

Stop Serializing Return Values for InvokeVoidAsync #35807

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ed267c5
Stop Serializing `InvokeVoidAsync` Return Value
TanayParikh Aug 26, 2021
ece4256
Fix E2E Test
TanayParikh Aug 26, 2021
33f0afc
Add JSObjectReferenceTest
TanayParikh Aug 27, 2021
e754872
Remove `IJSVoidResult` from the public API
TanayParikh Aug 27, 2021
0d885ee
Merge branch 'main' into taparik/invokeVoidReturnVal
TanayParikh Aug 27, 2021
1d060b8
release .js files
TanayParikh Aug 27, 2021
fdc5d19
Revert "Remove `IJSVoidResult` from the public API"
TanayParikh Aug 27, 2021
c5dda5e
Add monocrash to gitignore
TanayParikh Aug 27, 2021
5c1424b
Fix Tests
TanayParikh Aug 27, 2021
56c4af4
Merge branch 'taparik/invokeVoidReturnVal' of https://github.com/dotn…
TanayParikh Aug 27, 2021
71a6e39
Update src/JSInterop/Microsoft.JSInterop/src/PublicAPI.Unshipped.txt
TanayParikh Aug 27, 2021
e6635cc
PR Feedback @pranavkm
TanayParikh Aug 30, 2021
465262b
Merge branch 'main' into taparik/invokeVoidReturnVal
TanayParikh Aug 30, 2021
1170d19
Update src/JSInterop/Microsoft.JSInterop/src/Infrastructure/IJSVoidRe…
TanayParikh Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Remove IJSVoidResult from the public API" 
This reverts commit e754872.
  • Loading branch information
@TanayParikh
TanayParikh committed Aug 27, 2021
commit fdc5d19d69d81e08597cb9c2dc18491a3d26bc93
2 changes: 1 addition & 1 deletion src/JSInterop/Microsoft.JSInterop/src/IJSVoidResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace Microsoft.JSInterop
/// <summary>
/// Represents a void result from a JavaScript call.
TanayParikh marked this conversation as resolved.
Show resolved Hide resolved
/// </summary>
internal interface IJSVoidResult
public interface IJSVoidResult
pranavkm marked this conversation as resolved.
Show resolved Hide resolved
TanayParikh marked this conversation as resolved.
Show resolved Hide resolved
{
}
}
1 change: 1 addition & 0 deletions src/JSInterop/Microsoft.JSInterop/src/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#nullable enable
Microsoft.JSInterop.IJSVoidResult
Microsoft.JSInterop.IJSStreamReference
Microsoft.JSInterop.IJSStreamReference.Length.get -> long
Microsoft.JSInterop.IJSStreamReference.OpenReadStreamAsync(long maxAllowedSize = 512000, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<System.IO.Stream!>
Expand Down