Slightly better support for NativeAOT and trimming #35211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use explicit reflection to make sure primitive TryParse method are preserved for trimming - Also use explicit reflection to preserve HttpContext properties when using expression tree compilation. - This doesn't work for custom types (those need to be preserved by the application).
davidfowl
requested review from
BrennanConroy,
Pilchie and
Tratcher
as code owners
davidfowl
added
feature-minimal-actions
src/Shared/TryParseMethodCache.cs
Outdated
| } | ||
| else | ||
| { | ||
| foreach (var method in typeof(Enum).GetMethods(BindingFlags.Public | BindingFlags.Static)) |
There was a problem hiding this comment.
methodInfo = typeof(Enum).GetMethod(nameof(Enum.TryParse), 1, new Type[] { typeof(String), Type.MakeGenericMethodParameter(0).MakeByRefType() });Might be a bit shorter. Also, trimming will know to keep just the specific method.
typeof(Enum).GetMethods(BindingFlags.Public | BindingFlags.Static) keeps all public static methods on System.Enum.
There was a problem hiding this comment.
I wasn't sure how to write this. Thanks!
There was a problem hiding this comment.
I feel like I've just leveled up my reflection powers...
There was a problem hiding this comment.
I feel like I've just leveled up my reflection powers...
Glad I helped! But also, I'm a bit scared.
There was a problem hiding this comment.
@pranavkm come look at this magic.
- Level up generic reflection - Fix issues with TryParse
pranavkm
approved these changes
Aug 10, 2021
Comment on lines
+129
to
+132
| methodInfo = typeof(Enum).GetMethod( | ||
| nameof(Enum.TryParse), | ||
| BindingFlags.Public | BindingFlags.Static, | ||
| new[] { typeof(Type), typeof(string), typeof(object).MakeByRefType() }); |
There was a problem hiding this comment.
Suggested change
| methodInfo = typeof(Enum).GetMethod( | |
| nameof(Enum.TryParse), | |
| BindingFlags.Public | BindingFlags.Static, | |
| new[] { typeof(Type), typeof(string), typeof(object).MakeByRefType() }); | |
| methodInfo = typeof(Enum).GetMethod( | |
| nameof(Enum.TryParse), | |
| BindingFlags.Public | BindingFlags.Static, | |
| new[] { typeof(Type), typeof(string), typeof(object).MakeByRefType() }); |
Comment on lines
+136
to
+139
| methodInfo = typeof(Enum).GetMethod( | ||
| nameof(Enum.TryParse), | ||
| genericParameterCount: 1, | ||
| new[] { typeof(string), Type.MakeGenericMethodParameter(0).MakeByRefType() }); |
There was a problem hiding this comment.
Suggested change
| methodInfo = typeof(Enum).GetMethod( | |
| nameof(Enum.TryParse), | |
| genericParameterCount: 1, | |
| new[] { typeof(string), Type.MakeGenericMethodParameter(0).MakeByRefType() }); | |
| methodInfo = typeof(Enum).GetMethod( | |
| nameof(Enum.TryParse), | |
| genericParameterCount: 1, | |
| new[] { typeof(string), Type.MakeGenericMethodParameter(0).MakeByRefType() }); |
Comment on lines
+194
to
+197
| method = typeof(long).GetMethod( | ||
| nameof(long.TryParse), | ||
| BindingFlags.Public | BindingFlags.Static, | ||
| new[] { typeof(string), typeof(NumberStyles), typeof(IFormatProvider), typeof(long).MakeByRefType() }); |
There was a problem hiding this comment.
Suggested change
| method = typeof(long).GetMethod( | |
| nameof(long.TryParse), | |
| BindingFlags.Public | BindingFlags.Static, | |
| new[] { typeof(string), typeof(NumberStyles), typeof(IFormatProvider), typeof(long).MakeByRefType() }); | |
| method = typeof(long).GetMethod( | |
| nameof(long.TryParse), | |
| BindingFlags.Public | BindingFlags.Static, | |
| new[] { typeof(string), typeof(NumberStyles), typeof(IFormatProvider), typeof(long).MakeByRefType() }); |
| } | ||
| else if (type == typeof(int)) | ||
| { | ||
| method = typeof(int).GetMethod( |
There was a problem hiding this comment.
Formatting for all of these
ghost
added this to the
amcasey
added
the
area-minimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to this conversation
cc @jkotas @MichalStrehovsky @eerhardt