Remove unnecessary try-catch in Worker template #35127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was working around a bug in 6.0 (dotnet/runtime#56032) which will be fixed in 6.0. So we no longer need this in the default template.
ghost
added
the
area-mvc
davidfowl
approved these changes
Aug 6, 2021
BrennanConroy
approved these changes
Aug 6, 2021
|
The underlying bug is now fixed in dotnet/runtime. Merging. |
eerhardt
added a commit
to dotnet/docs
that referenced
this pull request
Sep 29, 2021
No need in `try-catch` for OperationCanceledException. See dotnet/aspnetcore#35127
IEvangelist
pushed a commit
to dotnet/docs
that referenced
this pull request
Sep 30, 2021
No need in `try-catch` for OperationCanceledException. See dotnet/aspnetcore#35127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Remove unnecessary try-catch in Worker template
PR Description
This was working around a bug in 6.0 (dotnet/runtime#56032) which will be fixed in 6.0. So we no longer need this in the default template.