Make the duplicate usings warnings go away #34324
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The value is low and they clash in vs 16.10/11
dougbu
reviewed
Jul 14, 2021
| @@ -111,6 +111,7 @@ | |||
| <PropertyGroup> | |||
| <!-- Ensure API docs are available. --> | |||
| <NoWarn>$(NoWarn.Replace('1591', ''))</NoWarn> | |||
| <NoWarn>$(NoWarn),0105</NoWarn> | |||
There was a problem hiding this comment.
I don't see these warnings in rolling builds of 'main'. Could this be conditional on '$(BuildingInsideVisualStudio)' == 'true'❔
Also concerned about doing this everywhere. How many projects or (maybe better) test asset directories need this suppression❔
There was a problem hiding this comment.
These are semi-colon delimited no?
There was a problem hiding this comment.
Also concerned about doing this everywhere. How many projects or (maybe better) test asset directories need this suppression❔
Just in middleware.snlf I get 174 errors across 25 projects, most of which are product assemblies.
This was referenced Jul 14, 2021
net461 Invalid option '10.0' for /langversion. Use '/langversion:?' to list supported values.
#34292
Closed
|
Replaced by #34346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.