Skip to content

Improve Codespaces + C# extension interaction #33614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2021
Merged

Improve Codespaces + C# extension interaction #33614

merged 1 commit into from
Jun 17, 2021

Conversation

captainsafia
Copy link
Member

  • Running restore.sh on postCreate ensures that the C# extension can preprocess the projects and support things like go-to definition and find references
  • Loading the projects dynamically (when the user opens a file in a project) improves perf and prevents loading projects that the user is not working with

@captainsafia captainsafia requested a review from Pilchie as a code owner June 17, 2021 16:41
@Pilchie
Copy link
Member

Pilchie commented Jun 17, 2021

This means that things like Find All References/Rename are less effective, since they won't affect projects that don't have any files open, but I understand the tradeoff.

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 17, 2021
@captainsafia
Copy link
Member Author

This means that things like Find All References/Rename are less effective, since they won't affect projects that don't have any files open, but I understand the tradeoff.

Yep, definitely optimizing for perf here. There's a noticeable lag in Codespaces as the C# extension tries to crunch all the projects.

@captainsafia captainsafia merged commit 968e667 into main Jun 17, 2021
@captainsafia captainsafia deleted the safia/update-dev-container branch June 17, 2021 18:56
@ghost ghost added this to the 6.0-preview7 milestone Jun 17, 2021
jeffl8n added a commit to jeffl8n/aspnetcore that referenced this pull request Sep 18, 2021
@jeffl8n
Merge branch 'main' into issue-33587
a698a17 
* main:
  Handle more cases with the new entry point pattern (dotnet#33500)
  [main] Update dependencies from dotnet/runtime dotnet/efcore (dotnet#33560)
  Refactor LongPolling in Java to avoid stackoverflow (dotnet#33564)
  Optimize QueryCollection (dotnet#32829)
  Switch to in-org action (dotnet#33610)
  Improve Codespaces + C# extension interaction (dotnet#33614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pilchie Pilchie Pilchie approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
6.0-preview7
Development

Successfully merging this pull request may close these issues.
2 participants
@captainsafia @Pilchie