Skip to content

[release/3.1] Update submodules #32630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2021
Merged

[release/3.1] Update submodules #32630

merged 2 commits into from
Jun 1, 2021

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented May 13, 2021

  • be explicit about what we're tracking
  • get the latest from googletest remote

nit:

  • shorten name of the MessagePack-CSharp submodule

@dougbu
[release/3.1] Update submodules
594620b 
- be explicit about what we're tracking
- get the latest from googletest remote

nit:
- change googletest name to match path
  - `set-branch` and other updates do weird things otherwise
  - but, this requires another `git submodule update --init` in some cases
@dougbu dougbu force-pushed the dougbu/submodules/3.1 branch from 0bafb57 to 594620b Compare May 13, 2021 01:06
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 13, 2021
@dougbu dougbu requested review from a team and pranavkm May 16, 2021 05:14
@dougbu dougbu marked this pull request as ready for review May 16, 2021 05:15
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label May 16, 2021
This was referenced May 17, 2021
Closed
Closed
Closed
@dougbu dougbu added this to the 3.1.17 milestone May 27, 2021
@dougbu dougbu mentioned this pull request Jun 1, 2021
Closed
@wtgodbe wtgodbe merged commit c386bc7 into release/3.1 Jun 1, 2021
@wtgodbe wtgodbe deleted the dougbu/submodules/3.1 branch June 1, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@pranavkm pranavkm Awaiting requested review from pranavkm

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher Tratcher is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
3.1.17
Development

Successfully merging this pull request may close these issues.
3 participants
@dougbu @wtgodbe @Pilchie