Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlazorTemplate test improvements #30907

Merged
merged 57 commits into from
Mar 24, 2021
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
0c1a690
Try splitting createbuildpublish from run
HaoK Mar 13, 2021
44cfcbf
Merge branch 'main' into haok/pworder
HaoK Mar 13, 2021
3f8f8df
Update BlazorWasmTemplateTest.cs
HaoK Mar 13, 2021
c4efe4b
Update BlazorWasmTemplateTest.cs
HaoK Mar 14, 2021
d5a4c14
Update BlazorServerTemplateTest.cs
HaoK Mar 14, 2021
78a4740
Update BlazorWasmTemplateTest.cs
HaoK Mar 15, 2021
24967f8
Try stop sharing playwright instance, create one per test
HaoK Mar 15, 2021
1da6a3f
Update BrowserManager.cs
HaoK Mar 15, 2021
a201a63
Update AssemblyInfo.AssemblyFixtures.cs
HaoK Mar 16, 2021
5c5d794
Update AssemblyInfo.AssemblyFixtures.cs
HaoK Mar 16, 2021
ccc0c10
Cleanup
HaoK Mar 16, 2021
d08ece3
Update BlazorTemplateTest.cs
HaoK Mar 16, 2021
38a926e
Update BlazorWasmTemplateTest.cs
HaoK Mar 16, 2021
e205d24
Update BlazorWasmTemplateTest.cs
HaoK Mar 16, 2021
e856f9e
Add logging
HaoK Mar 16, 2021
3d9921c
Merge branch 'haok/pworder' of https://github.com/dotnet/aspnetcore i…
HaoK Mar 16, 2021
778d568
Update BlazorWasmTemplateTest.cs
HaoK Mar 17, 2021
9b300b2
Update BlazorWasmTemplateTest.cs
HaoK Mar 17, 2021
c0aae25
Update BlazorTemplateTest.cs
HaoK Mar 17, 2021
9cbac95
Update AssemblyInfo.AssemblyFixtures.cs
HaoK Mar 17, 2021
488f245
Update BlazorWasmTemplateTest.cs
HaoK Mar 17, 2021
811ad99
Merge branch 'main' into haok/pworder
HaoK Mar 17, 2021
861afce
Update BlazorTemplateTest.cs
HaoK Mar 18, 2021
1569cb2
Update BlazorTemplateTest.cs
HaoK Mar 18, 2021
0e6f858
Update LoggedTestBase.cs
HaoK Mar 18, 2021
f2d395b
Update LoggedTestBase.cs
HaoK Mar 18, 2021
54d171e
Update BlazorTemplateTest.cs
HaoK Mar 19, 2021
e204476
Update BlazorTemplateTest.cs
HaoK Mar 19, 2021
d31198f
Update BlazorServerTemplateTest.cs
HaoK Mar 19, 2021
8b17ff6
Use correct logger
HaoK Mar 19, 2021
9ab5a85
Update BlazorTemplateTest.cs
HaoK Mar 19, 2021
d4b6365
Update BlazorServerTemplateTest.cs
HaoK Mar 19, 2021
ad3f974
Update BlazorTemplateTest.cs
HaoK Mar 19, 2021
9f47a47
Update BlazorWasmTemplateTest.cs
HaoK Mar 19, 2021
3dede55
Update src/Testing/src/LoggedTest/LoggedTestBase.cs
HaoK Mar 19, 2021
03c786f
Update LoggedTestBase.cs
HaoK Mar 19, 2021
d2c6bf8
Update BlazorTemplateTest.cs
HaoK Mar 19, 2021
e9d5124
Update MvcTemplateTest.cs
HaoK Mar 19, 2021
70a67c9
Update BlazorTemplateTest.cs
HaoK Mar 19, 2021
d6723c0
Update BlazorTemplateTest.cs
HaoK Mar 19, 2021
815ad0d
Hook testsink to actually do something!
HaoK Mar 20, 2021
2678751
Update BlazorTemplateTest.cs
HaoK Mar 20, 2021
968b57e
Pass output to project methods
HaoK Mar 20, 2021
e48461d
Fixup output helper in GetOrCreateProject
HaoK Mar 20, 2021
b7fadae
Merge branch 'main' into haok/pworder
HaoK Mar 20, 2021
c001819
Update Project.cs
HaoK Mar 20, 2021
5172e66
Update ProjectFactoryFixture.cs
HaoK Mar 20, 2021
69e6f31
Update Project.cs
HaoK Mar 21, 2021
f3f8317
Update MvcTemplateTest.cs
HaoK Mar 21, 2021
a050395
Update BlazorWasmTemplateTest.cs
HaoK Mar 22, 2021
495da51
Update BlazorServerTemplateTest.cs
HaoK Mar 22, 2021
9e38af3
Update comments to clarify test dependencies
HaoK Mar 22, 2021
4979b23
Update BlazorWasmTemplateTest.cs
HaoK Mar 22, 2021
36cdc1a
Update TestPriorityAttribute.cs
HaoK Mar 22, 2021
17fb968
Update BlazorWasmTemplateTest.cs
HaoK Mar 22, 2021
18865dd
Requarantine tests
HaoK Mar 23, 2021
a13c1f0
Requarantine tests
HaoK Mar 23, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update LoggedTestBase.cs
  • Loading branch information
HaoK authored Mar 18, 2021
commit 0e6f858eace7e35c0dfbe9444d7f5dddd0d58e8b
11 changes: 8 additions & 3 deletions src/Testing/src/LoggedTest/LoggedTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ public virtual void Initialize(TestContext context, MethodInfo methodInfo, objec
_initializationException = ExceptionDispatchInfo.Capture(e);
}
}

public virtual Task InitializeAsync(TestContext context, MethodInfo methodInfo, object[] testMethodArguments, ITestOutputHelper testOutputHelper)
{
Initialize(context, methodInfo, testMethodArguments, testOutputHelper);
return Task.CompletedTask;
}

HaoK marked this conversation as resolved.
Show resolved Hide resolved
public virtual void Dispose()
{
Expand All @@ -110,12 +116,11 @@ public virtual void Dispose()
_testLog.Dispose();
}

Task ITestMethodLifecycle.OnTestStartAsync(TestContext context, CancellationToken cancellationToken)
async Task ITestMethodLifecycle.OnTestStartAsync(TestContext context, CancellationToken cancellationToken)
{

Context = context;

Initialize(context, context.TestMethod, context.MethodArguments, context.Output);
await InitializeAsync(context, context.TestMethod, context.MethodArguments, context.Output);
return Task.CompletedTask;
}

Expand Down