Don't check stdout for entire string contents #30023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| EventLogHelpers.VerifyEventLogEvent(deploymentResult, EventLogHelpers.InProcessThreadExitStdOut(deploymentResult, "12", expectedString), Logger); | ||
| // Logs can be split due to the ANCM logging occuring at the same time as logs from the app, so check for a portion of the | ||
| // string instead of the entire string. The entire string will still be present in the event log. | ||
| var expectedLogString = new string('a', 16); |
There was a problem hiding this comment.
Could this have the same issue as the 30k a's, just a lot less likely?
There was a problem hiding this comment.
No, there are only a few log messages that can be spliced in between. So there is no way to split every string to a size smaller than 16.
BrennanConroy
approved these changes
Feb 9, 2021
Tratcher
approved these changes
Feb 9, 2021
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27178 (which is already closed).
Fixes #27858
My original fix didn't quite fix all flakiness. There still ends up being an issue where logs can be split due to logs from the app racing with ANCM logs. The goal of the test is to verify that some part of the log is actually logged to either the file or test sink. The other part is to verify that the event log happens with the entire message. So I changed the check to just check for a portion of the string in the log file to verify that we are actually logging to the file.