Skip AddressRegistrationTests Hostname tests on macOS #30012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Tratcher
reviewed
Feb 8, 2021
Tratcher
approved these changes
Feb 9, 2021
pranavkm
added a commit
that referenced
this pull request
Feb 10, 2021
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #27377.
From what I can tell, the skip condition itself still races with the actual acquisition of the socket in the test (aka the skip condition passes, but the test itself fails because of the same reason). I see that the skip condition is sometimes working (a few tests here are skipped https://dev.azure.com/dnceng/public/_test/analytics?definitionId=331&contextType=build) but a majority of the time it still fails.
I think the best option is to just skip these on macOS for now. I think we can beef up the description for why we want to skip these, but confirming this is the right direction we want to go.