Skip to content

Remove obsolete IHttpBufferingFeature, IHttpSendFileFeature #28890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Dec 29, 2020
Merged

Remove obsolete IHttpBufferingFeature, IHttpSendFileFeature #28890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions src/Http/Http.Features/src/IHttpBufferingFeature.cs
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions src/Http/Http.Features/src/IHttpSendFileFeature.cs
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions src/Http/Http.Features/src/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ Microsoft.AspNetCore.Http.Features.IFormFeature.ReadFormAsync(System.Threading.C
Microsoft.AspNetCore.Http.Features.IHttpBodyControlFeature
Microsoft.AspNetCore.Http.Features.IHttpBodyControlFeature.AllowSynchronousIO.get -> bool
Microsoft.AspNetCore.Http.Features.IHttpBodyControlFeature.AllowSynchronousIO.set -> void
Microsoft.AspNetCore.Http.Features.IHttpBufferingFeature
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there no concrete implementations for these feature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they were replaced in 3.0 by IHttpResponseBodyFeature.

Microsoft.AspNetCore.Http.Features.IHttpBufferingFeature.DisableRequestBuffering() -> void
Microsoft.AspNetCore.Http.Features.IHttpBufferingFeature.DisableResponseBuffering() -> void
Microsoft.AspNetCore.Http.Features.IHttpConnectionFeature
Microsoft.AspNetCore.Http.Features.IHttpConnectionFeature.ConnectionId.get -> string!
Microsoft.AspNetCore.Http.Features.IHttpConnectionFeature.ConnectionId.set -> void
Expand Down Expand Up @@ -134,8 +131,6 @@ Microsoft.AspNetCore.Http.Features.IHttpResponseFeature.StatusCode.set -> void
Microsoft.AspNetCore.Http.Features.IHttpResponseTrailersFeature
Microsoft.AspNetCore.Http.Features.IHttpResponseTrailersFeature.Trailers.set -> void
Microsoft.AspNetCore.Http.Features.IHttpResponseTrailersFeature.Trailers.get -> Microsoft.AspNetCore.Http.IHeaderDictionary!
Microsoft.AspNetCore.Http.Features.IHttpSendFileFeature
Microsoft.AspNetCore.Http.Features.IHttpSendFileFeature.SendFileAsync(string! path, long offset, long? count, System.Threading.CancellationToken cancellation) -> System.Threading.Tasks.Task!
Microsoft.AspNetCore.Http.Features.IHttpUpgradeFeature
Microsoft.AspNetCore.Http.Features.IHttpUpgradeFeature.IsUpgradableRequest.get -> bool
Microsoft.AspNetCore.Http.Features.IHttpUpgradeFeature.UpgradeAsync() -> System.Threading.Tasks.Task<System.IO.Stream!>!
Expand Down
13 changes: 0 additions & 13 deletions src/Servers/testassets/ServerComparison.TestSites/StartupResponseCompression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,6 @@ public void Configure(IApplicationBuilder app, ILoggerFactory loggerFactory)
return context.Response.WriteAsync(helloWorldBody);
});
});
/* If we implement DisableResponseBuffering on IISMiddleware
app.Map("/NoBuffer", subApp =>
{
subApp.UseResponseCompression();
subApp.Run(context =>
{
context.Features.Get<IHttpBufferingFeature>().DisableResponseBuffering();
context.Response.ContentType = "text/plain";
context.Response.ContentLength = helloWorldBody.Length;
return context.Response.WriteAsync(helloWorldBody);
});
});
*/
app.Run(context =>
{
context.Response.ContentType = "text/plain";
Expand Down