Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for generating app manifest files for tests #28575

Merged
merged 12 commits into from
Dec 17, 2020
Merged

Add support for generating app manifest files for tests #28575

merged 12 commits into from
Dec 17, 2020

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Dec 10, 2020 •
edited
Loading

Summary of the changes

  • Add GenerateMvcTestManifestTask to generate JSON file from list of projects and assemblies
  • Update testing targets to call GenerateMvcTestManifestTask
  • Update WebApplicationFactory to read content roots from JSON file

Addresses #27296

@captainsafia captainsafia requested a review from HaoK December 10, 2020 19:56
@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Dec 10, 2020
@captainsafia captainsafia force-pushed the testing/improve-helix-build branch from 291f8f7 to 656ca5f Compare December 15, 2020 00:08
@captainsafia captainsafia force-pushed the testing/improve-helix-build branch from 321debb to 6af95d8 Compare December 16, 2020 03:55
@captainsafia captainsafia force-pushed the testing/improve-helix-build branch from 6af95d8 to 6ce42ca Compare December 16, 2020 04:10
pranavkm
pranavkm approved these changes Dec 16, 2020
View reviewed changes
src/Mvc/Mvc.Testing.Tasks/src/GenerateMvcTestManifestTask.cs Outdated Show resolved Hide resolved
src/Mvc/Mvc.Testing.Tasks/src/Microsoft.AspNetCore.Mvc.Testing.Tasks.csproj Outdated Show resolved Hide resolved
src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.csproj Outdated Show resolved Hide resolved
src/Mvc/Mvc.Testing.Tasks/src/Microsoft.AspNetCore.Mvc.Testing.Tasks.csproj Show resolved Hide resolved
src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets Outdated Show resolved Hide resolved
src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets Show resolved Hide resolved
src/Mvc/Mvc.Testing/src/WebApplicationFactory.cs Outdated Show resolved Hide resolved
src/Mvc/Mvc.Testing/src/WebApplicationFactory.cs Outdated Show resolved Hide resolved
@captainsafia captainsafia merged commit f7e1712 into master Dec 17, 2020
@captainsafia captainsafia deleted the testing/improve-helix-build branch December 17, 2020 20:54
@martincostello martincostello mentioned this pull request Feb 18, 2021
Closed
martincostello added a commit to martincostello/website that referenced this pull request Mar 11, 2021
@martincostello
Fix tests
ddf2092 
Fix WebApplicationFactoryContentRootAttribute not being emitted due to changes in dotnet/aspnetcore#28575.
martincostello added a commit to martincostello/alexa-london-travel-site that referenced this pull request Mar 11, 2021
@martincostello
Fix tests
9f46da5 
Fix WebApplicationFactoryContentRootAttribute not being emitted due to changes in dotnet/aspnetcore#28575.
martincostello added a commit to martincostello/website that referenced this pull request Apr 8, 2021
@martincostello
Fix tests
37a2af5 
Fix WebApplicationFactoryContentRootAttribute not being emitted due to changes in dotnet/aspnetcore#28575.
martincostello added a commit to martincostello/alexa-london-travel-site that referenced this pull request Apr 8, 2021
@martincostello
Fix tests
7d3f678 
Fix WebApplicationFactoryContentRootAttribute not being emitted due to changes in dotnet/aspnetcore#28575.
martincostello added a commit to martincostello/alexa-london-travel-site that referenced this pull request Apr 10, 2021
@martincostello
Fix tests
50d5961 
Fix WebApplicationFactoryContentRootAttribute not being emitted due to changes in dotnet/aspnetcore#28575.
martincostello added a commit to martincostello/alexa-london-travel-site that referenced this pull request Apr 10, 2021
@martincostello
Fix tests
b7b7b8e 
Fix WebApplicationFactoryContentRootAttribute not being emitted due to changes in dotnet/aspnetcore#28575.
martincostello added a commit to martincostello/website that referenced this pull request May 25, 2021
@martincostello
Fix tests
d9e413f 
Fix WebApplicationFactoryContentRootAttribute not being emitted due to changes in dotnet/aspnetcore#28575.
martincostello added a commit to martincostello/alexa-london-travel-site that referenced this pull request May 25, 2021
@martincostello
Fix tests
f6ed4cf 
Fix WebApplicationFactoryContentRootAttribute not being emitted due to changes in dotnet/aspnetcore#28575.
martincostello added a commit to martincostello/alexa-london-travel-site that referenced this pull request Jun 7, 2021
@martincostello
Fix tests
cf2dabb 
Fix WebApplicationFactoryContentRootAttribute not being emitted due to changes in dotnet/aspnetcore#28575.
martincostello added a commit to martincostello/alexa-london-travel-site that referenced this pull request Jun 14, 2021
@martincostello
Fix tests
6f14eec 
Fix WebApplicationFactoryContentRootAttribute not being emitted due to changes in dotnet/aspnetcore#28575.
martincostello added a commit to martincostello/website that referenced this pull request Jun 17, 2021
@martincostello
Fix tests
7448c1a 
Fix WebApplicationFactoryContentRootAttribute not being emitted due to changes in dotnet/aspnetcore#28575.
martincostello added a commit to martincostello/alexa-london-travel-site that referenced this pull request Jun 17, 2021
@martincostello
Fix tests
647b2f2 
Fix WebApplicationFactoryContentRootAttribute not being emitted due to changes in dotnet/aspnetcore#28575.
@davidfowl davidfowl mentioned this pull request Jul 15, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HaoK HaoK HaoK left review comments

@pranavkm pranavkm pranavkm approved these changes

@javiercn javiercn Awaiting requested review from javiercn

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@captainsafia @pranavkm @HaoK @Pilchie